util: eliminate unnecessary exports#11451
Closed
jasnell wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
The getHiddenValue and setHiddenValue functions are exported from internalUtil for no really good reason
nodejs-github-bot
added
the
util
Member
Author
targos
approved these changes
Feb 18, 2017
lpinca
approved these changes
Feb 19, 2017
jasnell
added a commit
that referenced
this pull request
Feb 19, 2017
The getHiddenValue and setHiddenValue functions are exported from internalUtil for no really good reason PR-URL: #11451 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
Author
|
Landed in b855dad |
addaleax
pushed a commit
that referenced
this pull request
Feb 22, 2017
The getHiddenValue and setHiddenValue functions are exported from internalUtil for no really good reason PR-URL: #11451 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Member
Author
|
needs a backport PR to land in v4 or v6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The getHiddenValue and setHiddenValue functions are exported from internalUtil for no really good reason
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
internal util